Skip to content

Remove codeql for staging#992

Merged
chdinh merged 1 commit into
mne-tools:stagingfrom
larsoner:limit
May 2, 2026
Merged

Remove codeql for staging#992
chdinh merged 1 commit into
mne-tools:stagingfrom
larsoner:limit

Conversation

@larsoner

@larsoner larsoner commented May 1, 2026

Copy link
Copy Markdown
Member

Looking at https://github.com/mne-tools/mne-cpp/actions/workflows/codeql.yml I see 9 runners in the last 2h that will each be tied up for about an hour

Screenshot 2026-05-01 at 10 21 02 AM

This PR aims to reduce this usage by just running CodeQL on main. I am not sure what the dev workflow is here exactly, but assuming you merge stuff from staging to main occassionally then this would help with the concurrency issues.

Feel free to close and fix a different way, but it would be good to get something like this in ASAP so that other repo workflows can continue!

@larsoner

larsoner commented May 1, 2026

Copy link
Copy Markdown
Member Author

Ooof actually the runners are tied up for over 3h 😱

@larsoner

larsoner commented May 1, 2026

Copy link
Copy Markdown
Member Author

I am going to manually kill the CodeQL jobs in staging (except the latest commit), I hope that's okay @chdinh . Can restart them later if needed (esp. if a regression is seen)

@chdinh

chdinh commented May 2, 2026

Copy link
Copy Markdown
Member

@larsoner Thanks for reporting and for looking into this. I agree it’s safe for CodeQL not to be triggered on staging; running it on main should be sufficient for now.

@chdinh chdinh merged commit c1aacdb into mne-tools:staging May 2, 2026
7 of 10 checks passed
@chdinh

chdinh commented May 3, 2026

Copy link
Copy Markdown
Member

@larsoner, I have now introduced concurrency groups with cancel-in-progress: true. This should automatically cancel outdated runs when a newer run for the same branch/PR is triggered.

That should reduce the number of long-running jobs blocking the queue while still allowing us to include staging. What do you think?

@larsoner larsoner deleted the limit branch May 4, 2026 14:33
@larsoner

larsoner commented May 4, 2026

Copy link
Copy Markdown
Member Author

That should reduce the number of long-running jobs blocking the queue while still allowing us to include staging. What do you think?

We can try it! I'll keep an eye on the jobs and if they get backlogged consistently again we can revisit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants